Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 3, 2021

BREAKING CHANGE: recommend prefer-to-be rule

@G-Rath G-Rath requested a review from SimenB October 3, 2021 01:45
@G-Rath G-Rath force-pushed the add-rules-to-config-2 branch 2 times, most recently from 54a709f to a86994e Compare October 3, 2021 02:46
Comment on lines 95 to 96
"jest/prefer-to-be-null": "error",
"jest/prefer-to-be-undefined": "error",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be removed first (or at the same time)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I wanted to make the PR without setting it up to conflict when #918 is merged in

@G-Rath G-Rath changed the title feat: add prefer-to-be to style ruleset Adjust rules Oct 9, 2021
@G-Rath G-Rath requested a review from SimenB October 9, 2021 19:40
BREAKING CHANGE: recommend `prefer-to-be` rule
BREAKING CHANGE: removed `prefer-to-be-null` rule
BREAKING CHANGE: removed `prefer-to-be-undefined` rule
BREAKING CHANGE: renamed `lowercase-name` to `prefer-lowercase-title`
BREAKING CHANGE: renamed `valid-describe` to `valid-describe-callback`
@SimenB SimenB force-pushed the add-rules-to-config-2 branch from 58bf093 to 2fd507b Compare October 10, 2021 09:19
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo

@SimenB SimenB merged commit f3e9e9a into next Oct 10, 2021
@SimenB SimenB deleted the add-rules-to-config-2 branch October 10, 2021 09:22
@github-actions
Copy link

🎉 This PR is included in version 25.0.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants