Skip to content

ts-migration/convert-some-utils-functions #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 20, 2019
Merged

ts-migration/convert-some-utils-functions #315

merged 17 commits into from
Jul 20, 2019

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jul 19, 2019

This might cause issues with #310 but these three functions are the only ones from tsUtils that are required for about three or four rules, so getting these across the line will let me land those straight away :)

@SimenB
Copy link
Member

SimenB commented Jul 19, 2019

Coverage isn't happy... Would it be quick to port a rule which uses these?

@SimenB
Copy link
Member

SimenB commented Jul 19, 2019

I've merged #310 as well, fwiw. Doesn't seem like it created a merge conflict 🙂

@G-Rath
Copy link
Collaborator Author

G-Rath commented Jul 19, 2019

@SimenB done - I've pushed no-jasmine-globals :)

SimenB
SimenB approved these changes Jul 19, 2019
View reviewed changes
@SimenB
Copy link
Member

SimenB commented Jul 19, 2019

Tests and coverage is failing on ci, btw

G-Rath added 12 commits July 19, 2019 20:56
@G-Rath
Copy link
Collaborator Author

G-Rath commented Jul 19, 2019

@SimenB this is good to go!

I pulled in another rule (no-disabled-tests) to help improve the coverage, along w/ adding a couple more tests & re-arranging some type-narrowing if conditions so that they get hit before non-narrowing ones :)

Everything's now back at 100% coverage, and utils.js has gotten smaller since those two rules were the only ones using some of the methods :D

SimenB
SimenB reviewed Jul 20, 2019
View reviewed changes
src/rules/__tests__/no-jasmine-globals.test.ts
output: 'jest.setTimeout(5000);',
},
{
code: 'jasmine.DEFAULT_TIMEOUT_INTERVAL = function() {}',
Copy link
Member

@SimenB SimenB Jul 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this valid jasmine code?

Copy link
Member

@SimenB SimenB Jul 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to warn on it either way

Copy link
Collaborator Author

@G-Rath G-Rath Jul 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but it's technically something that could be done. Eitherway, it triggers the previously uncovered branch :)

@SimenB SimenB merged commit 7af272d into jest-community:reapply-ts Jul 20, 2019
@G-Rath G-Rath deleted the ts-migration/convert-some-utils-functions branch July 20, 2019 07:56
SimenB pushed a commit that referenced this pull request Jul 20, 2019
@G-Rath @SimenB
chore: migrate no-disabled-tests and no-jasmine-globals to TypeSc…
cb021e7 
…ript (#315)
@SimenB SimenB mentioned this pull request Jul 20, 2019
Closed
35 tasks
SimenB pushed a commit that referenced this pull request Jul 20, 2019
@G-Rath @SimenB
chore: migrate no-disabled-tests and no-jasmine-globals to TypeSc…
c213f26 
…ript (#315)
SimenB pushed a commit that referenced this pull request Jul 21, 2019
@G-Rath @SimenB
chore: migrate no-jasmine-globals to TypeScript (#315)
e4f7c6b
SimenB pushed a commit that referenced this pull request Jul 21, 2019
@G-Rath @SimenB
chore: migrate no-disabled-tests to TypeScript (#315)
c6baa43
SimenB pushed a commit that referenced this pull request Jul 21, 2019
@G-Rath @SimenB
chore: migrate no-jasmine-globals to TypeScript (#315)
7941365
SimenB pushed a commit that referenced this pull request Jul 21, 2019
@G-Rath @SimenB
chore: migrate no-disabled-tests to TypeScript (#315)
c9740c2
SimenB pushed a commit that referenced this pull request Jul 22, 2019
@G-Rath @SimenB
chore(no-jasmine-globals): migrate to TS (#315)
2a0db83
SimenB pushed a commit that referenced this pull request Jul 22, 2019
@G-Rath @SimenB
chore(no-disabled-tests): migrate to TS (#315)
be7b806
SimenB pushed a commit that referenced this pull request Jul 22, 2019
@G-Rath @SimenB
chore(no-jasmine-globals): migrate to TS (#315)
b27be0e
SimenB pushed a commit that referenced this pull request Jul 22, 2019
@G-Rath @SimenB
chore(no-disabled-tests): migrate to TS (#315)
fe2be18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G-Rath @SimenB