chore: migrate no-disabled-tests to TypeScript (#315)

Author: G-Rath

src/rules/__tests__/no-disabled-tests.test.js renamed to src/rules/__tests__/no-disabled-tests.test.ts

@@ -1,7 +1,7 @@
-import { RuleTester } from 'eslint';
+import { TSESLint } from '@typescript-eslint/experimental-utils';
 import rule from '../no-disabled-tests';
 
-const ruleTester = new RuleTester({
+const ruleTester = new TSESLint.RuleTester({
   parserOptions: {
     sourceType: 'module',
   },
@@ -15,6 +15,7 @@ ruleTester.run('no-disabled-tests', rule, {
     'it.only("foo", function () {})',
     'test("foo", function () {})',
     'test.only("foo", function () {})',
+    'describe[`${"skip"}`]("foo", function () {})',
     'var appliedSkip = describe.skip; appliedSkip.apply(describe)',
     'var calledSkip = it.skip; calledSkip.call(it)',
     '({ f: function () {} }).f()',
@@ -57,6 +58,10 @@ ruleTester.run('no-disabled-tests', rule, {
       code: 'describe.skip("foo", function () {})',
       errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }],
     },
+    {
+      code: 'describe[`skip`]("foo", function () {})',
+      errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }],
+    },
     {
       code: 'describe["skip"]("foo", function () {})',
       errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }],

src/rules/no-disabled-tests.js renamed to src/rules/no-disabled-tests.ts

@@ -1,9 +1,13 @@
-import { getDocsUrl, getNodeName, scopeHasLocalReference } from './util';
+import { createRule } from './tsUtils';
+import { getNodeName, scopeHasLocalReference } from './tsUtils';
 
-export default {
+export default createRule({
+  name: __filename,
   meta: {
     docs: {
-      url: getDocsUrl(__filename),
+      category: 'Best Practices',
+      description: 'Disallow disabled tests',
+      recommended: false,
     },
     messages: {
       missingFunction: 'Test is missing function argument',
@@ -16,7 +20,9 @@ export default {
       disabledTest: 'Disabled test',
     },
     schema: [],
+    type: 'suggestion',
   },
+  defaultOptions: [],
   create(context) {
     let suiteDepth = 0;
     let testDepth = 0;
@@ -72,4 +78,4 @@ export default {
       },
     };
   },
-};
+});

src/rules/util.js

@@ -184,44 +184,6 @@ export const getDocsUrl = filename => {
   return `${REPO_URL}/blob/v${version}/docs/rules/${ruleName}.md`;
 };
 
-const collectReferences = scope => {
-  const locals = new Set();
-  const unresolved = new Set();
-
-  let currentScope = scope;
-
-  while (currentScope !== null) {
-    for (const ref of currentScope.variables) {
-      const isReferenceDefined = ref.defs.some(def => {
-        return def.type !== 'ImplicitGlobalVariable';
-      });
-
-      if (isReferenceDefined) {
-        locals.add(ref.name);
-      }
-    }
-
-    for (const ref of currentScope.through) {
-      unresolved.add(ref.identifier.name);
-    }
-
-    currentScope = currentScope.upper;
-  }
-
-  return { locals, unresolved };
-};
-
-export const scopeHasLocalReference = (scope, referenceName) => {
-  const references = collectReferences(scope);
-  return (
-    // referenceName was found as a local variable or function declaration.
-    references.locals.has(referenceName) ||
-    // referenceName was not found as an unresolved reference,
-    // meaning it is likely not an implicit global reference.
-    !references.unresolved.has(referenceName)
-  );
-};
-
 export function composeFixers(node) {
   return (...fixers) => {
     return fixerApi => {