-
Notifications
You must be signed in to change notification settings - Fork 687
Implement realm object and support realms for built-ins and JS functions #4354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4738679 to
35485a8
Compare
|
Depends on #4352 |
0fd5939 to
faa948f
Compare
|
|
There is a 184 byte bss decrease and a 200 byte heap memory increase because the global object is stored on the heap now. Furthermore byte codes needs an extra 4 byte for realms. |
|
There was an 1.5K increase on access-binary-trees.js, so I run this test with |
faa948f to
1e68110
Compare
- Type for realm objects is introduced (ecma_global_object_t) - Realm reference is added to built-in objects and ECMAScript functions - Resolving built-ins, global environments, and scopes require realm object - Unnecessary global object accesses are removed from the code Missing: external functions and static snapshot functions have no realm reference JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
1e68110 to
821f36c
Compare
rerobika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Could you please add |
|
Of course. Next patch will also do several things. |
dbatyai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Missing: external functions and static snapshot functions have no realm reference