Add support test262 $262 global object support #4329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ossy-szeged
reviewed
Nov 10, 2020
kisbg
force-pushed
the
test262-object
branch
4 times, most recently
from
acba95e to
567d900
Compare
galpeter
reviewed
Nov 11, 2020
kisbg
force-pushed
the
test262-object
branch
4 times, most recently
from
e351b40 to
bf2236f
Compare
Author
|
@galpeter Thank your for the review! I updated the pull request based on your review. |
galpeter
reviewed
Nov 12, 2020
kisbg
force-pushed
the
test262-object
branch
from
bf2236f to
bffc911
Compare
rerobika
requested changes
Nov 16, 2020
kisbg
force-pushed
the
test262-object
branch
from
bffc911 to
485c65a
Compare
kisbg
changed the title
rerobika
requested changes
Nov 16, 2020
kisbg
force-pushed
the
test262-object
branch
from
485c65a to
87031e0
Compare
Member
|
Please rebase the PR. |
kisbg
force-pushed
the
test262-object
branch
from
87031e0 to
54147a5
Compare
galpeter
reviewed
Nov 20, 2020
galpeter
reviewed
Nov 20, 2020
kisbg
force-pushed
the
test262-object
branch
from
54147a5 to
041d3ec
Compare
Contributor
|
Please close already resolved reviews with "Resolve conversation" button. |
zherczeg
reviewed
Nov 25, 2020
jerry-main/main-utils.c
Outdated
| jerry_release_value (result_val); | ||
| } /* main_register_global_function */ | ||
|
|
||
| #if defined (JERRY_TEST262) && (JERRY_TEST262 == 1) |
Member
There was a problem hiding this comment.
What about doing this without a define? This is a simple test program, I don't see any issue to always have this comannd line feature.
rerobika
approved these changes
Dec 7, 2020
Member
rerobika
left a comment
rerobika
left a comment
There was a problem hiding this comment.
LGTM after this minor change
jerry-main/CMakeLists.txt
Outdated
| install(TARGETS ${JERRY_NAME} DESTINATION bin) | ||
| endmacro() | ||
|
|
||
|
|
Few test-cases in test262 uses a $262 object to run a few method (for example detachedArrayBuffer) JerryScript-DCO-1.0-Signed-off-by: bence gabor kis [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few test-cases in test262 uses a $262 object to run a few method (for example detachedArrayBuffer)
JerryScript-DCO-1.0-Signed-off-by: bence gabor kis [email protected]