feat(ui): add toggle for bbox with hotkey #8385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csehatt741
requested review from
psychedelicious,
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
requested changes
Aug 4, 2025
Comment on lines
199
to
201
|
|
||
| // Listen for stage changes to update the bbox's visibility | ||
| this.subscriptions.add(this.$isBboxHidden.listen((isHidden) => this.konva.group.visible(!isHidden))); |
There was a problem hiding this comment.
I think this hidden check should be in the render method, and the listener calls the render method. Otherwise the render method could run for some other reason, and make the bbox visible, even when it is hidden.
There was a problem hiding this comment.
Setting bbox visibility moved into the render method
csehatt741
force-pushed
the
feature/restore-bbox-hiding-functionality
branch
from
ac3ee6b to
7ef257f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new feature was implemented to show/hide the bounding box.
toggleBboxVisibility, was added toCanvasBboxToolModule, which toggles the visibility flag of the bounding box.useCanvasToggleBboxHotkey, was implemented and integrated intoCanvasToolbar. This registersShift+Oas a hotkey inuseHotkeyDatato trigger thetoggleBboxVisibilitymethod, providing a quick keyboard shortcut.CanvasAlertsBboxVisibility, was introduced, which shows a warning message, when the bounding box is hidden.en.jsonfor the warning message.Related Issues / Discussions
Closes #7182
QA Instructions
Checklist
What's Newcopy (if doing a release after this PR)