[enhancement]: restore bbox hiding functionality

[grebenshyo]

Is there an existing issue for this?

• I have searched the existing issues

Contact Details

No response

What should this feature add?

for some inexplicable reason, the bbox hiding functionality (shortcut shift+H) has been removed with the last update. the feature is crucial for the process of inpainting, when a user's focus shifts from the generation view to the whole view. having costantly the bbox border in the FOV makes it harder to check for the possible presence of visible seams, so the possibility of hiding it promptly to get a picture of the process is of primary importance. the only way for doing that as of now is by moving the bbox manually out of sight, which is obviously way too cumbersome for an efficient inpainting workflow.

Alternatives

No response

Additional Content

No response

[psychedelicious]

Should be fairly straightforward to restore this functionality. Here's how I would approach it:

• Add a flag to represent whether the bbox is hidden or not. I think this should be a nanostore in the CanvasBboxToolModule, so it'd be CanvasBboxToolModule.$isBboxHidden.
• Add a helper method to the bbox module called toggleBboxVisibility that toggles the flag.
• Add a listener to the nanostore that sets toggles visiblity of the bbox module's Konva group when the flag changes.
• Add a hotkey that calls toggleBboxVisibility.
• Add a canvas alert when the bbox is hidden. Model it off this component. The only difference is that instead of getting the flag from redux, use useCanvasManager() to get the manager instance, then do useStore(canvasManager.tool.tools.bbox.$isBboxHidden) to get the flag.

[grebenshyo]

not even quite sure where to start. i was able to find the file over here at some point, but not in my install. looks like that might be an issue with visibility configuration of the downloaded files?

[psychedelicious]

Not asking you to do those steps - it's notes for a contributor who might want to add the feature.

[grebenshyo]

oh, rofl, okay 👍🏾