fix dict.update implementation in list_models #1616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: devops117 <[email protected]>
lstein
reviewed
Nov 29, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
No offense, but list_models keeps breaking and I keep reverting. I don't know why it seemed to work the last time around, but it definitely stopped working yesterday. For both our sanities, I'm going to hold off on approving this change until after release 2.2 goes out. I really do appreciate your contributions!
Collaborator
|
@devops117 I've reissued this PR as #1764 in order to rebase against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for #1594