make the docstring more readable and improve the list_models logic (fixes #1539) #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: devops117 <[email protected]>
Signed-off-by: devops117 <[email protected]>
lstein
reviewed
Nov 28, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Due to time constraints, I will have to defer my review until later this week after the 2.2 release goes out. I am adding a couple other reviewers to the list, but we're all fairly maxed out at the moment.
I appreciate your persistence and patience!
damian0815
approved these changes
Nov 28, 2022
Contributor
damian0815
left a comment
damian0815
left a comment
There was a problem hiding this comment.
looks good to me, thanks for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1539 got reverted due to a bug I overlooked