Skip to content

Conversation

@jb-balaji
Copy link

Fixed bash script all the errors and warnings reported by shellcheck tool

Signed-off-by: Sathiyamoorthi, Jayabalaji [email protected]

Copy link
Contributor

@LewisLiuPub LewisLiuPub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for updates.

@LewisLiuPub LewisLiuPub merged commit 74d3686 into intel:ros2 Mar 4, 2025
LewisLiuPub pushed a commit that referenced this pull request Mar 4, 2025
jb-balaji added a commit to jb-balaji/ros2_openvino_toolkit that referenced this pull request Mar 4, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0
------------------------------------------------------------
* Creating docker container for ROS2 Humble with OpenVINO 2025.0.0

* Enable OV2025 experimental support

* Docker file and a header file is updated.  Code is compiling
without errors and a simple image pipeline demo is run.
Detailed testing required.

* Minor refactoring of the dockerfile to accept OpenVINO version, add nano package
Created the README document to build, setup and run the docker container

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

* fix merging conflicts.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321)

Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

---------

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>
Signed-off-by: Liu, Wei Zhi <[email protected]>
Co-authored-by: Liu, Wei Zhi <[email protected]>
jb-balaji added a commit to jb-balaji/ros2_openvino_toolkit that referenced this pull request Mar 4, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0
------------------------------------------------------------
* Creating docker container for ROS2 Humble with OpenVINO 2025.0.0

* Enable OV2025 experimental support

* Docker file and a header file is updated.  Code is compiling
without errors and a simple image pipeline demo is run.
Detailed testing required.

* Minor refactoring of the dockerfile to accept OpenVINO version, add nano package
Created the README document to build, setup and run the docker container

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

* fix merging conflicts.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321)

Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

---------

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>
Signed-off-by: Liu, Wei Zhi <[email protected]>
Co-authored-by: Liu, Wei Zhi <[email protected]>
jb-balaji added a commit to jb-balaji/ros2_openvino_toolkit that referenced this pull request Mar 6, 2025
jb-balaji added a commit to jb-balaji/ros2_openvino_toolkit that referenced this pull request Mar 6, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0
------------------------------------------------------------
* Creating docker container for ROS2 Humble with OpenVINO 2025.0.0

* Enable OV2025 experimental support

* Docker file and a header file is updated.  Code is compiling
without errors and a simple image pipeline demo is run.
Detailed testing required.

* Minor refactoring of the dockerfile to accept OpenVINO version, add nano package
Created the README document to build, setup and run the docker container

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

* fix merging conflicts.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321)

Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

---------

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>
Signed-off-by: Liu, Wei Zhi <[email protected]>
Co-authored-by: Liu, Wei Zhi <[email protected]>
jb-balaji added a commit to jb-balaji/ros2_openvino_toolkit that referenced this pull request Mar 6, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0
------------------------------------------------------------
* Creating docker container for ROS2 Humble with OpenVINO 2025.0.0

* Enable OV2025 experimental support

* Docker file and a header file is updated.  Code is compiling
without errors and a simple image pipeline demo is run.
Detailed testing required.

* Minor refactoring of the dockerfile to accept OpenVINO version, add nano package
Created the README document to build, setup and run the docker container

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

* fix merging conflicts.

Signed-off-by: Liu, Wei Zhi <[email protected]>

* Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321)

Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>

---------

Signed-off-by: Arshad Mehmood <[email protected]>
Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>
Signed-off-by: Liu, Wei Zhi <[email protected]>
Co-authored-by: Liu, Wei Zhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants