This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[wip] Export cmake plugin interface #363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't supposed to be used by anyone (client or plugin). Signed-off-by: David Wagner <[email protected]>
Signed-off-by: David Wagner <[email protected]>
On UNIX systems, headers used to be spread across 3 directories under the include dir, leading to, for instance, installing a "/usr/include/utility" directory... They are now all under a single subdir: <prefix>/include/parameter. Signed-off-by: David Wagner <[email protected]>
…dirs We used to manually add them for almost all targets. Having CMake do it automatically simplifies the makefiles. Signed-off-by: David Wagner <[email protected]>
The functional tests rely on at least one libpfw_utility-provided feature: the BinaryCopy class. Therefore, it must explicitly link against it. Signed-off-by: David Wagner <[email protected]>
A Package Configuration file lets other CMake projects easily use our own installed project, simply by calling find_package(ParameterFramework). There is a known bug in CMake 3.2's find_dependency macro; this is worked around by shipping a patched copy of this macro. See https://cmake.org/Bug/view.php?id=15412. Known issue: because of dependency leakage, the xmlserializer and pfw_utility static libraries are exported even though they are not supposed to be used by anyone. The related CMake documentation can be found at https://cmake.org/cmake/help/v3.2/manual/cmake-packages.7.html#package-configuration-file Signed-off-by: David Wagner <[email protected]>
Instead of linking against ParameterFramework::parameter, plugins may now link against ParameterFramework::plugin. This has the added value of preventing the installation of libxmlserializer.a and libpfw_utility.a. Signed-off-by: David Wagner <[email protected]>
Current coverage is
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains #362.
80.34%@@ master #363 diff @@ ====================================== Files 211 211 Stmts 7169 7169 Branches 0 0 Methods 0 0 ====================================== Hit 5760 5760 Partial 0 0 Missed 1409 1409