Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

@dawagner
Copy link
Contributor


@@            master    #362   diff @@
======================================
Files          211     211
Stmts         7169    7169
Branches         0       0
Methods          0       0
======================================
Hit           5760    5760
Partial          0       0
Missed        1409    1409

Review entire Coverage Diff as of f0059f3

Powered by Codecov. Updated on successful CI builds.

  

It isn't supposed to be used by anyone (client or plugin).

Signed-off-by: David Wagner <[email protected]>
On UNIX systems, headers used to be spread across 3 directories under the
include dir, leading to, for instance, installing a "/usr/include/utility"
directory...

They are now all under a single subdir: <prefix>/include/parameter.

Signed-off-by: David Wagner <[email protected]>
…dirs

We used to manually add them for almost all targets. Having CMake do it
automatically simplifies the makefiles.

Signed-off-by: David Wagner <[email protected]>
The functional tests rely on at least one libpfw_utility-provided feature: the
BinaryCopy class. Therefore, it must explicitly link against it.

Signed-off-by: David Wagner <[email protected]>
@dawagner dawagner force-pushed the export-cmake branch 2 times, most recently from 15bede5 to 6796b42 Compare March 23, 2016 16:54
@codecov-io
Copy link

Current coverage is 80.34%

Merging #362 into master will not affect coverage as of 06211b7

@@            master    #362   diff @@
======================================
  Files          211     211       
  Stmts         7169    7169       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           5760    5760       
  Partial          0       0       
  Missed        1409    1409       

Review entire Coverage Diff as of 06211b7

Powered by Codecov. Updated on successful CI builds.

@dawagner dawagner changed the title CMake: generate and install a Package Configuration file [review] CMake: generate and install a Package Configuration file Mar 23, 2016
@tcahuzax
Copy link
Contributor

👍

"${CMAKE_CURRENT_BINARY_DIR}/ParameterFrameworkConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/ParameterFrameworkConfigVersion.cmake"
DESTINATION lib/cmake/ParameterFramework
COMPONENT Devel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove as this does not work

@krocard
Copy link
Contributor

krocard commented Mar 24, 2016

👍

1 similar comment
@tcahuzax
Copy link
Contributor

👍

A Package Configuration file lets other CMake projects easily use our own
installed project, simply by calling find_package(ParameterFramework). Also,
Instead of linking against ParameterFramework::parameter, plugins may now link
against ParameterFramework::plugin. This has the added value of preventing the
installation of libxmlserializer.a and libpfw_utility.a.

The related CMake documentation can be found at
https://cmake.org/cmake/help/v3.2/manual/cmake-packages.7.html#package-configuration-file

Signed-off-by: David Wagner <[email protected]>
@dawagner dawagner merged commit 58d2da1 into intel:master Mar 24, 2016
@dawagner dawagner deleted the export-cmake branch March 24, 2016 17:09
@dawagner dawagner changed the title [review] CMake: generate and install a Package Configuration file CMake: generate and install a Package Configuration file Mar 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants