Skip to content

Conversation

@PenghuiCheng
Copy link
Contributor

Type of Change

Code quality
API changed

Description

Remove some redundant classes for quantization, benchmark and mixed precision

Expected Behavior & Potential Risk

quantization/mixed precision/benchmark work fine.

How has this PR been tested?

Local tested

Signed-off-by: Cheng, Penghui <[email protected]>
@PenghuiCheng PenghuiCheng requested a review from zehao-intel May 5, 2023 03:27
@chensuyue
Copy link
Contributor

Can we unify the parameter config and conf in def fit(..., config=None, ...)?
For neural_compressor/benchmark.py, neural_compressor/mix_precision.py, neural_compressor/quantization.py.

Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
@chensuyue
Copy link
Contributor

/Azurepipeline run UT-Basic

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ftian1 ftian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of them are ok for me. I leave some comments here, pls revise them

Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
@PenghuiCheng PenghuiCheng removed the WIP label May 8, 2023
@ftian1
Copy link
Contributor

ftian1 commented May 8, 2023

Can we unify the parameter config and conf in def fit(..., config=None, ...)? For neural_compressor/benchmark.py, neural_compressor/mix_precision.py, neural_compressor/quantization.py.

I have same concerns here. if we unify to conf, is it a incompatible change comparing with INC 2.1 release?

@chensuyue chensuyue merged commit c510969 into master May 9, 2023
@chensuyue chensuyue deleted the penghuic/rewrite_api branch May 9, 2023 05:49
yiliu30 pushed a commit to yiliu30/neural-compressor that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants