Skip to content

[SYCL] Move integer conversion out of assert #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

[SYCL] Move integer conversion out of assert #7329

merged 1 commit into from
Nov 9, 2022

Conversation

@steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Nov 9, 2022

Converting the aspect values in sycl-device-has in the SYCL propagate aspect usage pass was unintentionally done inside an assert. This causes the conversion to not take place when asserts are disabled. This commit moves the conversion out of the assertion.

@steffenlarsen
[SYCL] Move integer conversion out of assert
7f3fe40 
Converting the aspect values in sycl-device-has in the SYCL propagate
aspect usage pass was unintentionally done inside an assert. This causes
the conversion to not take place when asserts are disabled. This commit
moves the conversion out of the assertion.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner November 9, 2022 10:06
@steffenlarsen steffenlarsen mentioned this pull request Nov 9, 2022
Merged
@steffenlarsen
Copy link
Contributor Author

steffenlarsen commented Nov 9, 2022

CI failures are unrelated:

  1. Basic/barrier_order.cpp sporadic timeout on L0.
  2. Regression/device_num.cpp on various targets. ([SYCL] Replace SYCL_DEVICE_FILTER with ONEAPI_DEVICE_SELECTOR llvm-test-suite#1354 (comment))
  3. regression/tanh_fix_test.cpp unexpectedly passing on ESIMD emulator. ([SYCL][ESIMD] Add test to validate tanh function fix llvm-test-suite#1361 (comment))
  4. Basic/barrier_order.cpp sporadic failure on HIP. (Basic/barrier_order.cpp hangs on opencl:gpu #7330)

@steffenlarsen steffenlarsen merged commit 6dbeb2e into intel:sycl Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steffenlarsen @AlexeySachkov