[SYCL] Replace SYCL_DEVICE_FILTER with ONEAPI_DEVICE_SELECTOR #1354
Conversation
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
raaiq1
requested review from
a team,
kbobrovs and
rolandschulz
as code owners
|
/verify with intel/llvm#7207 |
Signed-off-by: Rauf, Rana <[email protected]>
|
Failure SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp is seen in other PRs |
|
Ping to @intel/llvm-reviewers-runtime , @intel/dpcpp-l0-pi-reviewers or @intel/dpcpp-tools-reviewers for review |
| // RUN: env ONEAPI_DEVICE_SELECTOR="*:cpu" %t.out | ||
| // RUN: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu %t.out | ||
| // RUN: env ONEAPI_DEVICE_SELECTOR=opencl:gpu %t.out | ||
| // RUN: env ONEAPI_DEVICE_SELECTOR='*:cpu;level_zero:gpu' %t.out |
There was a problem hiding this comment.
Is there some logic behind when ' is used and when " is used?
There was a problem hiding this comment.
There's functionally no difference between ' and ". Sorry for the inconsistent usage of between the two
There was a problem hiding this comment.
Not a big problem so I am fine with it as-is.
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
|
@raaiq1 - Regression/device_num.cpp is failing in a number of CI configurations after this change. See for example https://github.com/intel/llvm/actions/runs/3427185876/jobs/5710263986. |
|
Hi. The regression is caused by ONEAPI_DEVICE_SELECTOR implicitly allowing ESIMD backend even though it shouldn't. There's a patch for it here: intel/llvm#7336 |
…1354) -Modified tests and config to use ONEAPI_DEVICE_SELECTOR instead of SYCL_DEVICE_FILTER -Added to test to check for warning message when using setting SYCL_DEVICE_FILTER environment variable
…llvm-test-suite#1354) -Modified tests and config to use ONEAPI_DEVICE_SELECTOR instead of SYCL_DEVICE_FILTER -Added to test to check for warning message when using setting SYCL_DEVICE_FILTER environment variable
5 participants
-Modified tests and config to use ONEAPI_DEVICE_SELECTOR instead of SYCL_DEVICE_FILTER
-Added to test to check for warning message when using setting SYCL_DEVICE_FILTER environment variable