[SYCL] Resolve namespace ambiguity in this_nd_item #5258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `detail` namespace appears in both the `sycl` namespace and in the `sycl::ext::oneapi::experimental` namespace, the implementation of `sycl::ext::oneapi::experimental::this_nd_item` may fail due to `detail::declptr` not existing in the latter. These changes remove the ambiguity. Signed-off-by: Steffen Larsen <[email protected]>
bader
previously approved these changes
Jan 10, 2022
sycl/test/basic_tests/free_function_queries/free_function_queries_interface.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Steffen Larsen <[email protected]>
s-kanaev
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
detailnamespace appears in both thesyclnamespace and in thesycl::ext::oneapi::experimentalnamespace, the implementation ofsycl::ext::oneapi::experimental::this_nd_itemmay fail due todetail::declptrnot existing in the latter. These changes remove the ambiguity.