Skip to content

[SYCL] Resolve namespace ambiguity in this_nd_item #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022
Merged

[SYCL] Resolve namespace ambiguity in this_nd_item #5258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f15813
[SYCL] Resolve namespace ambiguity in this_nd_item
steffenlarsen Jan 4, 2022
4431e8c
Use SYCL_EXTERNAL and remove main
steffenlarsen Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sycl/include/CL/sycl/nd_item.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ namespace oneapi {
namespace experimental {
template <int Dims> nd_item<Dims> this_nd_item() {
#ifdef __SYCL_DEVICE_ONLY__
return sycl::detail::Builder::getElement(detail::declptr<nd_item<Dims>>());
return sycl::detail::Builder::getElement(
sycl::detail::declptr<nd_item<Dims>>());
#else
throw sycl::exception(
sycl::make_error_code(sycl::errc::feature_not_supported),
Expand Down
2 changes: 1 addition & 1 deletion sycl/test/basic_tests/free_function_queries/free_function_queries_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ template <template <int, bool = true> class Item, int Dims> void test() {
"Wrong return type of free function query for Item");
}

int main() {
SYCL_EXTERNAL void test_all() {
test<sycl::id>(this_id_caller<1>{});
test<sycl::id>(this_id_caller<2>{});
test<sycl::id>(this_id_caller<3>{});
Expand Down