[SYCL] Align local memory extension with spec changes #4346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sergey-semenov
commented
Aug 16, 2021
sergey-semenov
commented
- Move group_local_memory* to sycl::ext::oneapi
- Define SYCL_EXT_ONEAPI_LOCAL_MEMORY feature test macro
- Move group_local_memory* to sycl::ext::oneapi - Define SYCL_EXT_ONEAPI_LOCAL_MEMORY feature test macro
Contributor
Author
|
Aligns the implementation with #4326 |
Pennycook
previously approved these changes
Aug 16, 2021
romanovvlad
previously approved these changes
Aug 16, 2021
sergey-semenov
dismissed stale reviews from romanovvlad and Pennycook
via
0c25297
romanovvlad
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.