-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL][Doc] Modernize LocalMemory extension #4326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Brings LocalMemory extension in line with other extensions: - Written against SYCL 2020 - Feature test macro - sycl::ext::oneapi namespace This commit replaces the old SYCL 1.2.1 extension completely in favor of a SYCL 2020 extension, because the SYCL 1.2.1 extension has not yet been marked implemented. Signed-off-by: John Pennycook <[email protected]>
|
Modernizing the documentation ahead of marking the extension "implemented" as discussed in #4323. While converting to the new extension format I noticed a few typos and copy-paste errors, which this commit also fixes. @sergey-semenov: Tagging you so that you can double-check this matches the implementation. |
|
The example is most useful. It would be further useful if the document better explained how |
gmlueck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This document is better viewed when rendered as html with asciidoctor. GitHub does not render image icons.
I did not include this statement in some of the more recent spec's I've written. In my experience GitHub renders the asciidoctor sources pretty well, and I think we would want to encourage people to use the GitHub rendering. Asking people to clone the repo, install asciidoctor, and run it manually is a real pain. Do you really think we need this statement?
Built On: {docdate} +
I also did not include this line in my recent specs. When you use the GitHub rendering, this simply shows the current date, which is not useful. If you want the spec to contain a date, it would be better to hard-code here. Alternatively, it may be better to use use the revision number to identify revisions of the spec.
Brings LocalMemory extension in line with other extensions:
This commit replaces the old SYCL 1.2.1 extension completely
in favor of a SYCL 2020 extension, because the SYCL 1.2.1 extension
has not yet been marked implemented.
Signed-off-by: John Pennycook [email protected]