[SYCL] Fix a typo in test regression/device_num.cpp #3286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is simple. ">=" ==> ">" The original code was written assuming the device_num starts at 1. As I changed the code to start device_num at 0, the condition of test should have been changed to NOT run when the test is going over the total number of devices found in the system. Signed-off-by: Byoungro So <[email protected]>
smaslov-intel
approved these changes
Mar 2, 2021
iclsrc
pushed a commit
that referenced
this pull request
Aug 5, 2025
The LLVM coding standard [1] generally prefers static function declarations, so turn off the `misc-use-anonymous-namespaces` option that suggests using anonymous namespaces. [1] https://llvm.org/docs/CodingStandards.html#restrict-visibility Original commit: KhronosGroup/SPIRV-LLVM-Translator@9dc4849fbc3fa9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is simple.
">=" ==> ">"
The original code was written assuming the device_num starts at 1.
As I changed the code to start device_num at 0, the condition of test
should have been changed to NOT run when the test is going over the total
number of devices found in the system.
Signed-off-by: Byoungro So [email protected]