Revert "[SYCL] Change the definition of device number to use the 'sycl-ls' tool" #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
approved these changes
Mar 2, 2021
bso-intel
suggested changes
Mar 2, 2021
Contributor
bso-intel
left a comment
bso-intel
left a comment
There was a problem hiding this comment.
sycl/test/regression/device_num.cpp is the new test I added as a part of PR 3095.
I will check what the problem is.
In the worst case, just reverting the test device_num.cpp is appropriate. Not the entire PR.
Contributor
|
@vmaksimo , I just tested the test device_num.cpp on my machine, and it passed. |
Contributor
|
I created a PR #3286 to fix the bug in device_num.cpp. |
Contributor
|
The fix for post-commit failure was submitted in scope of #3286. No need to revert the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3095, because SYCL :: regression/device_num.cpp test fails in Post-Commit checks