[SYCL] Switch Level Zero plugin to specification v1.0 #2408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added caching of L0 command lists per pi device - Command list created with an associated fence to track when the command list has successfully executed by the command queue - Added SYCL_PI_LEVEL0_MAX_COMMAND_LIST_CACHE environment variable to set the maximum cache size (default: 20000)
- Fixed issue where command list reuse between queues failed to properly add a new fence to the map. Signed-off-by: Spruit, Neil R <[email protected]> Signed-off-by: Byoungro So <[email protected]>
Add temporary support to enable online linking with the Level Zero driver if the SYCL_ENABLE_LEVEL_ZERO_LINK environment variable is set. At the time this code was written, the Level Zero driver online linking APIs exist, but they don't work. We think the DPC++ runtime support is ready, though, and we can enable it via this environment variable. This will allow testing with a new driver if one is available before the next DPC++ release.
againull
requested review from
a team,
kbobrovs,
pvchupin and
smaslov-intel
as code owners
smaslov-intel
approved these changes
Sep 3, 2020
Contributor
smaslov-intel
left a comment
smaslov-intel
left a comment
There was a problem hiding this comment.
LGTM, but it should be merged with the uplift of L0 version in CI.
Contributor
Author
|
This branch was merged in scope of #2409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.