[SYCL] change level0 to level_zero. #2235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbegam <[email protected]>
|
please approve @bader |
I can do this, but in order to merge this PR code owners must approve as well. In this particular case runtime code owners must approve. |
|
ping @alexbatashev |
alexbatashev
approved these changes
Aug 1, 2020
|
@rbegam, please, fix regressions in pre-commit testing. |
|
@rbegam, ping. |
|
Closing due to lack of activity. Please, feel free to reopen. |
bader
reviewed
Aug 26, 2020
| @@ -1,4 +1,4 @@ | |||
| // REQUIRES: opencl || level0 | |||
|
I am submitting a new PR related to this lit-test. |
jsji
pushed a commit
that referenced
this pull request
Nov 30, 2023
There is a fundamental misalignment between when translating llvm.ptr.annotation to SPIRV's OpMemberDecorate. llvm.ptr.annotation is applied onto a pointer. OpMemberDecorate is applied on a type, which means that all variables of this type will have this Decoration. This change fixes this misalignment by translating llvm.ptr.annotation to SPIRV's OpDecorate instead, which instead places the decoration onto the pointer. Original commit: KhronosGroup/SPIRV-LLVM-Translator@3770469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rbegam [email protected]