[SYCL] Separate OpenCL specific constructs from lit tests. #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding 'opencl' requirement disabled several tests some of which have non-opencl constructs as well. This patch separates those tests to enable testing of SYCL core functionalities. Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
vladimirlaz
suggested changes
Jul 21, 2020
| @@ -1,4 +1,4 @@ | |||
| // REQUIRES: opencl | |||
| // REQUIRES: opencl || level0 | |||
There was a problem hiding this comment.
I wonder how clCreateUserEvent call below will be processed if only Level0 RT is available
There was a problem hiding this comment.
clCreateUserEvent is not called for host and the test sets SYCL_DEVICE_TYPE=HOST. Do you suggest separating this test too?
There was a problem hiding this comment.
I am not quite understand the logic of the test:
- if we force HOST device lines 26-31 are dead code.
- It looks like the whole test check host events. What is the reason for having OpenCL or Level0 BE?
There was a problem hiding this comment.
that is true. I am modifying this.
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
|
see my comment above |
Signed-off-by: rbegam <[email protected]>
vladimirlaz
approved these changes
Jul 31, 2020
bader
reviewed
Jul 31, 2020
| @@ -1,7 +1,10 @@ | |||
| // REQUIRES: opencl | |||
| // REQUIRES: opencl || level0 | |||
There was a problem hiding this comment.
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
To support multi-device AOT scenario in SYCL we need an ability to create UR program from multiple device binaries. Changes in this PR: * Modify the core function `urProgramCreateWithBinary` to support program creation from multiple device binaries. * Add methods to ur_program to get/set per-device data like L0 module handle, build log etc. Otherwise any change in the structure of the class requires multiple changes in all UR functions which work with ur_program, in addition to this it allows to handle interop case (which implementation is an exception right now) in a single place. Also make State and some other info per-device because it is possible that UR program is associated with multiple devices and urProgramBuildExp is called multiple times for subsets, and we have to know the state per-device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 'opencl' requirement disabled several tests some of which
have non-opencl constructs as well. This patch separates those tests
to enable testing of SYCL core functionalities.
Signed-off-by: rbegam [email protected]