Skip to content

[NFC][SYCL] Simplify variadic_iterator usage #19507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

aelovikov-intel
Copy link
Contributor

std::weak_ptr<node_impl> aren't used to create nodes_range anymore (#19438 being the last change that enabled that, I think) and we also added SyclTy template parameter to variadic_iterator so that the dereference operator can be implemented in a generic way in the base class.

`std::weak_ptr<node_impl>` aren't used to create `nodes_range`
anymore (intel#19438 being the last change
that enabled that, I think) and we also added `SyclTy` template
parameter to `variadic_iterator` so that the dereference operator can be
implemented in a generic way in the base class.
@aelovikov-intel
Copy link
Contributor Author

@intel/sycl-graphs-reviewers this is relatively trivial and after it'll get merged, I'd be able to upload subsequent PR without triggering graph reviews, can you please take a quicker look at this?

@sergey-semenov , your review is necessary too.

@aelovikov-intel aelovikov-intel merged commit 4608d74 into intel:sycl Jul 21, 2025
41 of 43 checks passed
@aelovikov-intel aelovikov-intel deleted the variadic_iterator branch July 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants