Skip to content

[NFC][SYCL][Graph] Store raw node_impl * in MPredecessors/MSuccessors #19438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

aelovikov-intel
Copy link
Contributor

Continuation of #19295 and #19332.

Copy link
Contributor

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aelovikov-intel aelovikov-intel merged commit ab6210b into intel:sycl Jul 16, 2025
26 checks passed
@aelovikov-intel aelovikov-intel deleted the node_impl-succ-pred branch July 16, 2025 19:04
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Jul 17, 2025
`std::weak_ptr<node_impl>` aren't used to create `nodes_range`
anymore (intel#19438 being the last change
that enabled that, I think) and we also added `SyclTy` template
parameter to `variadic_iterator` so that the dereference operator can be
implemented in a generic way in the base class.
aelovikov-intel added a commit that referenced this pull request Jul 21, 2025
`std::weak_ptr<node_impl>` aren't used to create `nodes_range` anymore
(#19438 being the last change that
enabled that, I think) and we also added `SyclTy` template parameter to
`variadic_iterator` so that the dereference operator can be implemented
in a generic way in the base class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants