Skip to content

[SYCL][NFC] Rename Adapter to adapter_impl #19184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 27, 2025
Merged

[SYCL][NFC] Rename Adapter to adapter_impl #19184

merged 5 commits into from
Jun 27, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jun 26, 2025 •
edited by aelovikov-intel
Loading

So that we could do adapter_impl &Adapter = getAdapter(...); without breaking naming convention for variables. Also aligns with other *_impl classes, e.g. adapter_impl/ur_adapter_handle_t is similar to device_impl/ur_device_handle_t.

@uditagarwal97 uditagarwal97 self-assigned this Jun 26, 2025
@uditagarwal97 uditagarwal97 requested review from a team as code owners June 26, 2025 21:09
uditagarwal97
uditagarwal97 commented Jun 26, 2025
View reviewed changes
@uditagarwal97 uditagarwal97 merged commit b7d9ea9 into sycl Jun 27, 2025
25 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit/adaptermutex branch June 27, 2025 13:55
This was referenced Jun 27, 2025
Merged
Merged
uditagarwal97 added a commit that referenced this pull request Jul 1, 2025
@uditagarwal97
[SYCL][NFC] Pass adapter by reference in backend[_impl] (#19187)
b747578 
It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
uditagarwal97 added a commit that referenced this pull request Jul 3, 2025
@uditagarwal97
[SYCL][NFC] Pass adapter by ref in ur::getAdapter and event:getAdapter (
49405f5 
#19202)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
@uditagarwal97 uditagarwal97 mentioned this pull request Jul 4, 2025
Merged
uditagarwal97 added a commit that referenced this pull request Jul 4, 2025
@uditagarwal97
[SYCL][NFC] Make queue::getAdapter() return adapter ref instead of ptr (
b707123 
#19299)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
#19202
This was referenced Jul 4, 2025
Open
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongreig aarongreig aarongreig approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uditagarwal97 @aarongreig @aelovikov-intel