Skip to content

[DeviceSanitizers] Adjust backtrace addresses to call instruction #17404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2025
Merged

[DeviceSanitizers] Adjust backtrace addresses to call instruction #17404

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
433fb10
save
yingcong-wu Mar 12, 2025
121913d
save
yingcong-wu Mar 12, 2025
6dc2f8f
fix ci
yingcong-wu Mar 12, 2025
3d77d6c
fix alias
yingcong-wu Mar 12, 2025
4b976a3
fix alias
yingcong-wu Mar 12, 2025
0f69ef7
fix alias
yingcong-wu Mar 12, 2025
b51e080
fix alias
yingcong-wu Mar 12, 2025
9fe4ad2
address offline comment
yingcong-wu Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions unified-runtime/source/loader/layers/sanitizer/sanitizer_common/linux/backtrace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "sanitizer_common/sanitizer_stacktrace.hpp"

#include <execinfo.h>
#include <stdint.h>
#include <string>

namespace ur_sanitizer_layer {
Expand All @@ -21,9 +22,15 @@ StackTrace GetCurrentBacktrace() {
BacktraceFrame Frames[MAX_BACKTRACE_FRAMES];
int FrameCount = backtrace(Frames, MAX_BACKTRACE_FRAMES);

// The Frames contain the return addresses, which is one instruction after the
// call instruction. Adjust the addresses so that symbolizer would give more
// precise result.
for (int I = 0; I < FrameCount; I++) {
Frames[I] = (void *)((uintptr_t)Frames[I] - 1);
}

StackTrace Stack;
Stack.stack =
std::vector<BacktraceFrame>(&Frames[0], &Frames[FrameCount - 1]);
Stack.stack = std::vector<BacktraceFrame>(&Frames[0], &Frames[FrameCount]);

return Stack;
}
Expand Down