Skip to content

Conversation

@yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Mar 12, 2025

backtrace() would return buffers with return addresses, which is one instruction past the call. If that instruction belongs to other source lines, then the llvm-symbolizer would give out wrong result.
Test will be added internally. It is hard to write test for this using SYCL as SYCL does not generate code with that pattern.

@yingcong-wu yingcong-wu requested a review from a team as a code owner March 12, 2025 11:19
@yingcong-wu yingcong-wu changed the title save [DeviceSanitizers] Adjust backtrace addresses to call instruction Mar 12, 2025
@yingcong-wu
Copy link
Contributor Author

Hi @intel/unified-runtime-reviewers , please review this change. Thanks.

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , please help merge this PR. Thanks.

@steffenlarsen steffenlarsen merged commit 76c6653 into intel:sycl Mar 14, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants