-
Notifications
You must be signed in to change notification settings - Fork 794
[DeviceSanitizers] Adjust backtrace addresses to call instruction #17404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 8 commits into
intel:sycl
from
yingcong-wu:yc/0312-dsan-backtrace-fix
Mar 14, 2025
Merged
[DeviceSanitizers] Adjust backtrace addresses to call instruction #17404
steffenlarsen
merged 8 commits into
intel:sycl
from
yingcong-wu:yc/0312-dsan-backtrace-fix
Mar 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaomaosu
approved these changes
Mar 13, 2025
AllanZyne
approved these changes
Mar 13, 2025
Contributor
Author
|
Hi @intel/unified-runtime-reviewers , please review this change. Thanks. |
aarongreig
approved these changes
Mar 13, 2025
Contributor
Author
|
Hi @intel/llvm-gatekeepers , please help merge this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backtrace()would return buffers with return addresses, which is one instruction past the call. If that instruction belongs to other source lines, then the llvm-symbolizer would give out wrong result.Test will be added internally. It is hard to write test for this using SYCL as SYCL does not generate code with that pattern.