Skip to content

[SYCL][Graph] Add missing exception for USM memset #11945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[SYCL][Graph] Add missing exception for USM memset #11945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ event queue_impl::memset(const std::shared_ptr<detail::queue_impl> &Self,
// Emit a begin/end scope for this call
PrepareNotify.scopedNotify((uint16_t)xpti::trace_point_type_t::task_begin);
#endif
if (MGraph.lock()) {
throw sycl::exception(make_error_code(errc::invalid),
"The memset feature is not yet available "
"for use with the SYCL Graph extension.");
}

if (MHasDiscardEventsSupport) {
MemoryManager::fill_usm(Ptr, Self, Count, Value,
getOrWaitEvents(DepEvents, MContext), nullptr);
Expand Down
19 changes: 19 additions & 0 deletions sycl/unittests/Extensions/CommandGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,6 +1720,25 @@ TEST_F(CommandGraphTest, KernelPropertiesExceptionCheck) {
KernelFunction);
}

TEST_F(CommandGraphTest, USMMemsetShortcutExceptionCheck) {

const size_t N = 10;
unsigned char *Arr = malloc_device<unsigned char>(N, Queue);
int Value = 77;

Graph.begin_recording(Queue);

std::error_code ExceptionCode = make_error_code(sycl::errc::success);
try {
Queue.memset(Arr, Value, N);
} catch (exception &Exception) {
ExceptionCode = Exception.code();
}
ASSERT_EQ(ExceptionCode, sycl::errc::invalid);

Graph.end_recording(Queue);
}

TEST_F(CommandGraphTest, Memcpy2DExceptionCheck) {
constexpr size_t RECT_WIDTH = 30;
constexpr size_t RECT_HEIGHT = 21;
Expand Down