[SYCL][Graph] Add missing exception for USM memset #11945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throws a invalid exception when memset queue shortcut is used during graph recording since memset is not supported by the current graph implementation. Adds a unitest checking that the exception is correctly thrown. Addresses issue intel#11940
EwanC
approved these changes
Nov 20, 2023
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime Could we get a review on this please |
|
I have a question. What is needed to support memset ? The memset feature is not yet available for use with the SYCL Graph extension. |
This functionality is in PRs that are going through review: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws a invalid exception when memset queue shortcut is used during graph recording since memset is not supported by the current graph implementation.
Adds a unitest checking that the exception is correctly thrown.
Addresses issue #11940