Skip to content

Conversation

@bader
Copy link
Contributor

@bader bader commented Jul 12, 2023

We used to generate two header files to source directory, so .gitignore
file protected developers from committing auto-generated files.
f3b5fad
changed the directory for emitted files from source to build. Now we
don't need this .gitignore file anymore.

We used to generate two header files to source directory, so .gitignore
file protected developers from committing auto-generated files.
intel@f3b5fad
changed the directory for emitted files from source to build. Now we
don't need this .gitignore file anymore.
@bader bader requested a review from a team as a code owner July 12, 2023 23:23
@bader bader requested a review from aelovikov-intel July 12, 2023 23:23
@bader
Copy link
Contributor Author

bader commented Jul 12, 2023

For fellow DPC++ developers
I cloned the source directory quite a long time ago and this .gitignore file was hiding two auto-generated files in the source directory for months. I noticed that after sycl/test/extensions/macro.cpp failed on clean HEAD of the sycl branch. The test checks SYCL_EXT_ONEAPI_BACKEND_LEVEL_ZERO is equal to 5, but it turned out to be 3 on my system. It looks like the compiler adds include path to the DPC++ headers from source directory before the include path in build directory and pick up the outdated feature_test.hpp.
The recipe for this issue is to remove auto-generated headers from /sycl/* directory.

@bader bader temporarily deployed to aws July 12, 2023 23:37 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws July 13, 2023 00:18 — with GitHub Actions Inactive
@bader bader merged commit 29446ef into intel:sycl Jul 13, 2023
@bader bader deleted the gitignore-cleanup branch July 13, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants