This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Fixed out-of-bounds behavior for btx mN,rN instructions #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexAltea Thanks. I’m traveling and AFK. May not be able to give you much feedback on these PRs until next Monday... |
|
Have a nice trip! Tomorrow I'll head to HITB until Novermber 30th, so I'll be mostly AFK until then as well. |
raphaelning
suggested changes
Nov 27, 2018
|
All done. Once this passes your review, I'll squash it into a single commit (the first one) if you want. |
raphaelning
reviewed
Dec 4, 2018
The bit-test instructions BT/BTC/BTR/BTS, through the variant `bt* mN,rN`, allow selecting bytes outside the value referenced by the memory operand. This is now checked for all instructions flagged with INSN_BITOP. Corresponding tests have been added as well. See also: Intel SDM Vol. 2A: Figure 3-2. Memory Bit Indexing. Additionally, the test_read_memory and test_write_memory functions have dropped the `ea &= 0xFF` line since to prevent subtle bugs related to memory addressing. The correctness of the memory address will be verified. Signed-off-by: Alexandro Sanchez Bach <[email protected]>
Done! |
raphaelning
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported at #132 (comment).
The bit-test instructions BT/BTC/BTR/BTS, through the variant
bt* mN,rN, allow selecting bytes outside the value referenced by the memory operand. This is now checked for all instructions flagged with INSN_BITOP. Corresponding tests have been added as well (they have been cross-checked with tests run on my CPU).See also: Intel SDM Vol. 2A: Figure 3-2. Memory Bit Indexing.
Signed-off-by: Alexandro Sanchez Bach [email protected]