Refactor: Replace StakeAddressPayload with StakeCredential
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistency across modules.
# Conflicts: # common/src/address.rs # common/src/stake_addresses.rs # modules/accounts_state/src/snapshot.rs # modules/accounts_state/src/state.rs # modules/rest_blockfrost/src/handlers/epochs.rs # modules/stake_delta_filter/src/utils.rs
lowhung
commented
Oct 24, 2025
| } | ||
|
|
||
| pub fn get_credential(&self) -> Credential { | ||
| match &self.payload { |
Collaborator
Author
There was a problem hiding this comment.
This getter feels a bit silly now
This was referenced Oct 24, 2025
lowhung
force-pushed
the
lowhung/remove-stake-address-payload
branch
from
3898ca1 to
0e84a10
Compare
whankinsiv
reviewed
Oct 24, 2025
whankinsiv
reviewed
Oct 24, 2025
Collaborator
whankinsiv
left a comment
whankinsiv
left a comment
There was a problem hiding this comment.
Looks great overall. My only suggestion is to use the fixed size ScriptHash and AddrKeyHash for the Credential enum so we have a guarantee that these are the correct size.
whankinsiv
approved these changes
Oct 24, 2025
Collaborator
whankinsiv
left a comment
whankinsiv
left a comment
There was a problem hiding this comment.
Please create an issue for switching Credential to use the types defined in hash.rs. As discussed this is a larger refactor which can be addressed in a follow up PR due to all the to_vec() conversions in the codebase.
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.