Skip to content

Conversation

@ahnv
Copy link
Member

@ahnv ahnv commented Jun 1, 2021

#26

Copy link
Collaborator

@imagekitio imagekitio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has conflicts that must be resolved,

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request introduces 2 alerts and fixes 2 when merging 8778de6 into fdc49af - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@ahnv ahnv requested a review from imagekitio June 11, 2021 20:07
@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request fixes 2 alerts when merging 6e9c50a into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@ahnv ahnv changed the title WIP: Typescript support Typescript support Jun 11, 2021
Direct Typescript files will be used in mocha tests instead of transpiled js
Moved mocha configuration to .mochrc.json
@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request fixes 2 alerts when merging 9aeec1f into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request fixes 2 alerts when merging a59720a into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #37 (153ad43) into master (fdc49af) will increase coverage by 1.19%.
The diff coverage is 92.30%.

❗ Current head 153ad43 differs from pull request most recent head ec243e5. Consider uploading reports for the commit ec243e5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   91.46%   92.65%   +1.19%     
==========================================
  Files           7        9       +2     
  Lines         164      177      +13     
  Branches        0       38      +38     
==========================================
+ Hits          150      164      +14     
+ Misses         14        6       -8     
- Partials        0        7       +7     
Impacted Files Coverage Δ
src/utils/respond.ts 75.00% <ø> (ø)
src/utils/request.ts 84.00% <64.70%> (ø)
src/utils/transformation.ts 94.11% <85.71%> (ø)
src/upload/index.ts 89.28% <89.28%> (ø)
src/constants/errorMessages.ts 100.00% <100.00%> (ø)
src/constants/supportedTransforms.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/url/builder.ts 100.00% <100.00%> (ø)
src/url/index.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc49af...ec243e5. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request fixes 2 alerts when merging 5675085 into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@ahnv ahnv requested a review from violetviolinist June 11, 2021 21:48
@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request fixes 2 alerts when merging f261504 into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jun 14, 2021

This pull request fixes 2 alerts when merging 31fa2dc into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@ahnv ahnv changed the title Typescript support IMAGEKIT-56 Typescript support Jun 23, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2021

This pull request fixes 2 alerts when merging 6bb8aef into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2021

This pull request fixes 2 alerts when merging 0cfe4cf into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2021

This pull request fixes 2 alerts when merging ec243e5 into fdc49af - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

Copy link
Contributor

@eco-line eco-line left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@imagekitio imagekitio merged commit 7955295 into imagekit-developer:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants