Increased coverage and fixed comment in UrlOptions

Author: ahnv

src/interfaces/UrlOptions.ts

@@ -60,6 +60,6 @@ export interface UrlOptionsPath extends UrlOptionsBase {
 /**
  * Options for generating an URL
  *
- * @link https://github.com/imagekit-developer/imagekit-nodejs#url-generation
+ * @link https://github.com/imagekit-developer/imagekit-javascript#url-generation
  */
 export type UrlOptions = UrlOptionsSrc | UrlOptionsPath;

src/utils/transformation.ts

@@ -18,9 +18,6 @@ export default {
     validParameters: (options: ImageKitOptions) =>  {
         return VALID_TRANSFORMATION_POSITIONS.indexOf(options.transformationPosition) != -1;
     },
-    getSupportedTransforms: function () {
-        return supportedTransforms;
-    },
     getTransformKey: function (transform: string) {
         if (!transform) { return ""; }
 

test/initialization.js

@@ -7,14 +7,22 @@ import ImageKit from "../src/index";
 describe("Initialization checks", function () {
     var imagekit = new ImageKit(initializationParams);
 
-    it('should throw error', function () {
+    it('should throw error: options - empty object', function () {
         try {
             new ImageKit({});
         } catch(err) {
             expect(err.message).to.be.equal('Missing urlEndpoint during SDK initialization');
         }
     });
 
+    it('should throw error: options - undefined', function () {
+        try {
+            new ImageKit();
+        } catch(err) {
+            expect(err.message).to.be.equal('Missing urlEndpoint during SDK initialization');
+        }
+    });
+
     it('Pass private Key', function () {
         try {
             new ImageKit({
@@ -52,4 +60,12 @@ describe("Initialization checks", function () {
         expect(imagekit.upload).to.exist.and.to.be.a('function');
 
     });
+
+    it('should throw error: invalid transformationPosition', function () {
+        try {
+            new ImageKit({...initializationParams, transformationPosition: "test"});
+        } catch(err) {
+            expect(err.message).to.be.equal('Invalid transformationPosition parameter');
+        }
+    });
 });

test/upload.js

@@ -90,6 +90,16 @@ describe("File upload", function () {
         server.restore();
     });
 
+    it('Invalid Options', function () {
+
+        var callback = sinon.spy();
+
+        imagekit.upload(undefined, callback);
+        expect(server.requests.length).to.be.equal(0);
+        expect(callback.calledOnce).to.be.true;
+        sinon.assert.calledWith(callback, { help: "", message: "Invalid uploadOptions parameter" }, null);
+    });
+
     it('Missing fileName', function () {
         const fileOptions = {
             file: "https://ik.imagekit.io/remote-url.jpg"

test/url-generation.js

@@ -15,6 +15,12 @@ describe("URL generation", function () {
         expect(url).equal("");
     });
 
+    it('invalid src url', function () {
+        const url = imagekit.url({ src: "/" });
+
+        expect(url).equal("");
+    });
+
     it('no transformation path', function () {
         const url = imagekit.url({
             path: "/test_path.jpg"
@@ -214,6 +220,42 @@ describe("URL generation", function () {
         expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,b-20_FF0000/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
     });
 
+     it('transformation with empty key and empty value', function () {
+        const url = imagekit.url({
+            path: "/test_path.jpg",
+            transformation: [{
+                "": ""
+            }]
+        })
+
+        expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:-/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
+    });
+    
+    /**
+     * Provided to provide support to a new transform without sdk update
+     */
+    it('transformation with undefined transform', function () {
+        const url = imagekit.url({
+            path: "/test_path.jpg",
+            transformation: [{
+                "undefined-transform": "true"
+            }]
+        })
+
+        expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:undefined-transform-true/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
+    });
+
+    it('transformation with empty key and value', function () {
+        const url = imagekit.url({
+            path: "/test_path.jpg",
+            transformation: [{
+                effectContrast: "-"
+            }]
+        })
+
+        expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:e-contrast/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
+    });
+
     it('All combined', function () {
         const url = imagekit.url({
             path: "/test_path.jpg",