Skip to content

chore: include execution stats when logging slow query warn message #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2022
Merged

chore: include execution stats when logging slow query warn message #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a260448
chore: include execution stats when logging slow query warn message
surajpuvvada Jan 24, 2022
6e075c9
update google protobuf to 3.19.2
surajpuvvada Jan 24, 2022
1dd0de6
update google protobuf to 3.19.2 in other modules
surajpuvvada Jan 24, 2022
a3b4016
update google protobuf to 3.19.2 in other modules
surajpuvvada Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions query-service-api/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ val generateLocalGoGrpcFiles = false

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:3.15.6"
artifact = "com.google.protobuf:protoc:3.19.2"
}
plugins {
// Optional: an artifact spec for a protoc plugin, with "grpc" as
Expand Down Expand Up @@ -72,5 +72,5 @@ dependencies {
api("javax.annotation:javax.annotation-api:1.3.2")

testImplementation("org.junit.jupiter:junit-jupiter:5.7.1")
testImplementation("com.google.protobuf:protobuf-java-util:3.15.6")
testImplementation("com.google.protobuf:protobuf-java-util:3.19.2")
}
2 changes: 1 addition & 1 deletion query-service-impl/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ dependencies {
implementation("org.slf4j:slf4j-api:1.7.32")
implementation("commons-codec:commons-codec:1.15")
implementation("org.hypertrace.core.serviceframework:platform-metrics:0.1.33")
implementation("com.google.protobuf:protobuf-java-util:3.15.6")
implementation("com.google.protobuf:protobuf-java-util:3.19.2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep protoc versions aligned if updating:

query-service/query-service-api/build.gradle.kts

Line 19 in 641e419

artifact = "com.google.protobuf:protoc:3.15.6"

implementation("com.google.guava:guava:30.1.1-jre")
implementation("io.reactivex.rxjava3:rxjava:3.0.11")
implementation("com.squareup.okhttp3:okhttp:4.9.1")
Expand Down
5 changes: 3 additions & 2 deletions ...-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,10 +416,11 @@ public Observable<Row> handleRequest(
if (requestTimeMs > slowQueryThreshold) {
try {
LOG.warn(
"Query Execution time: {} ms, sqlQuery: {}, queryRequest: {}",
"Query Execution time: {} ms, sqlQuery: {}, queryRequest: {}, executionStats: {}",
requestTimeMs,
pql.getKey(),
protoJsonPrinter.print(request));
protoJsonPrinter.print(request),
resultSetGroup.getExecutionStats());
} catch (InvalidProtocolBufferException ignore) {
}
}
Expand Down
2 changes: 1 addition & 1 deletion query-service/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies {

runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:2.17.1")
runtimeOnly("io.grpc:grpc-netty")
integrationTestImplementation("com.google.protobuf:protobuf-java-util:3.17.3")
integrationTestImplementation("com.google.protobuf:protobuf-java-util:3.19.2")
integrationTestImplementation("org.junit.jupiter:junit-jupiter:5.7.1")
integrationTestImplementation("org.testcontainers:testcontainers:1.16.2")
integrationTestImplementation("org.testcontainers:junit-jupiter:1.16.2")
Expand Down