chore: include execution stats when logging slow query warn message #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajpuvvada
requested review from
aaron-steinfeld,
avinashkolluru,
laxman-traceable and
a team
aaron-steinfeld
previously approved these changes
Jan 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
============================================
- Coverage 81.70% 81.66% -0.04%
+ Complexity 592 591 -1
============================================
Files 58 58
Lines 2268 2269 +1
Branches 234 234
============================================
Hits 1853 1853
- Misses 319 321 +2
+ Partials 96 95 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -40,7 +40,7 @@ dependencies { | |||
| implementation("org.slf4j:slf4j-api:1.7.32") | |||
| implementation("commons-codec:commons-codec:1.15") | |||
| implementation("org.hypertrace.core.serviceframework:platform-metrics:0.1.33") | |||
| implementation("com.google.protobuf:protobuf-java-util:3.15.6") | |||
| implementation("com.google.protobuf:protobuf-java-util:3.19.2") | |||
There was a problem hiding this comment.
Please keep protoc versions aligned if updating:
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.