Skip to content

chore: adjust time agnostic comment for neighbor entities builder #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

skjindal93
Copy link
Contributor

Description

Taking care of a nit comment #66 (comment)

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@skjindal93 skjindal93 requested a review from a team as a code owner January 25, 2021 09:19
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #67 (76e7bc4) into main (d17be2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #67   +/-   ##
=========================================
  Coverage     55.96%   55.96%           
  Complexity       41       41           
=========================================
  Files            20       20           
  Lines           377      377           
  Branches         18       18           
=========================================
  Hits            211      211           
  Misses          162      162           
  Partials          4        4           
Flag Coverage Δ Complexity Δ
unit 55.96% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17be2c...76e7bc4. Read the comment docs.

@github-actions

This comment has been minimized.

@skjindal93 skjindal93 merged commit 9f6b20d into main Jan 25, 2021
@skjindal93 skjindal93 deleted the fix+time+agnostic+comment branch January 25, 2021 14:20
@github-actions
Copy link

Unit Test Results

  7 files  ±0    7 suites  ±0   11s ⏱️ ±0s
15 tests ±0  15 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9f6b20d. ± Comparison against base commit d17be2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants