perf(entities): set fetch total flag, if requested #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjindal93
changed the title
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
=========================================
Coverage 55.96% 55.96%
Complexity 41 41
=========================================
Files 20 20
Lines 377 377
Branches 18 18
=========================================
Hits 211 211
Misses 162 162
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Jan 24, 2021
| // that the neighbors would have to be live in the requested time range. Supporting time | ||
| // agnostic interations would mean a change in the way interactions are implemented | ||
| false, | ||
| // entity interactions doesn't support time agnostic nature, and would mean |
There was a problem hiding this comment.
nit: this comment applies to the boolean above
3 tasks
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
* fix: apply limit on span log fetch * chore: upgrade jetty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting
fetchTotalon EntitiesRequest, only if thetotalhas been requestedChecklist: