Added build method for explore-request-builder #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explore API is now being used as part of other APIs too (like events) which do not inherently support many of the functionalities that explore does.. One requirement is to build the request using pre-defined scope and manipulating the arguments instead of using the user-entered arguments as is. Hnece, added an overloaded build method which takes all the arguments as parameters.
singhalprerana
requested review from
aaron-steinfeld,
skjindal93 and
avinashkolluru
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
============================================
- Coverage 22.83% 22.81% -0.03%
Complexity 75 75
============================================
Files 65 65
Lines 1734 1736 +2
Branches 51 53 +2
============================================
Hits 396 396
- Misses 1329 1331 +2
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
skjindal93
approved these changes
Mar 7, 2022
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explore API is now being used as part of other APIs too (like events) which do not inherently support many of the functionalities that explore does..
One requirement is to build the request using pre-defined scope and manipulating the arguments instead of using the user-entered arguments as is.
Hence, added an overloaded build method which takes all the arguments as parameters.