Skip to content

Added build method with explorerScope in ExploreRequestBuilder #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

singhalprerana
Copy link
Contributor

@singhalprerana singhalprerana commented Mar 4, 2022

Explore API is now being used as part of other APIs too (like events) which do not inherently support many of the functionalities that explore does..
One requirement is to build the request using pre-defined scope instead of taking its value as argument.
Hence made the overloaded build method public which takes the explorerScope as one of the parameters.

@singhalprerana singhalprerana requested a review from a team as a code owner March 4, 2022 14:43
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #137 (209001e) into main (a03e544) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #137   +/-   ##
=========================================
  Coverage     22.83%   22.83%           
  Complexity       75       75           
=========================================
  Files            65       65           
  Lines          1734     1734           
  Branches         51       51           
=========================================
  Hits            396      396           
  Misses         1329     1329           
  Partials          9        9           
Flag Coverage Δ
unit 22.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...explorer/request/DefaultExploreRequestBuilder.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03e544...209001e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results

11 files  ±0  11 suites  ±0   18s ⏱️ -1s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 209001e. ± Comparison against base commit a03e544.

@singhalprerana
Copy link
Contributor Author

Closing in favour of #138

@singhalprerana singhalprerana deleted the explore/request/build-method branch March 7, 2022 06:30
skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
* fix: update graphql java version

* add suppression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant