Adding enabled, description fields to label application rules #115
Conversation
...org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java
Outdated
Show resolved
Hide resolved
| data.getName(), | ||
| conditionList, | ||
| labelAction, | ||
| data.getEnabled(), |
There was a problem hiding this comment.
Did we handle backwards compat at the config layer? Or planning to handle it manually since this full feature isn't exposed yet? Current impl will default any pre-existing rules to disabled since that's the default value of the new boolean.
There was a problem hiding this comment.
There are no existing label application rule. Checked in saas-dev.
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage ? 23.03%
Complexity ? 75
=======================================
Files ? 65
Lines ? 1680
Branches ? 52
=======================================
Hits ? 387
Misses ? 1284
Partials ? 9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.