Skip to content

Commit 2647937

Browse files
Adding enabled, description fields to label application rules (#115)
1 parent a024396 commit 2647937

File tree

6 files changed

+43
-7
lines changed

6 files changed

+43
-7
lines changed

hypertrace-graphql-label-application-rules-schema/src/main/java/org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleRequestConverter.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.hypertrace.graphql.label.application.rules.dao;
22

33
import java.util.List;
4+
import java.util.Optional;
45
import java.util.stream.Collectors;
56
import org.hypertrace.graphql.label.application.rules.request.LabelApplicationRuleCreateRequest;
67
import org.hypertrace.graphql.label.application.rules.request.LabelApplicationRuleDeleteRequest;
@@ -47,11 +48,14 @@ public DeleteLabelApplicationRuleRequest convertDeleteRequest(
4748

4849
private LabelApplicationRuleData convertLabelApplicationRuleData(
4950
org.hypertrace.graphql.label.application.rules.schema.shared.LabelApplicationRuleData data) {
50-
return LabelApplicationRuleData.newBuilder()
51-
.setName(data.name())
52-
.setMatchingCondition(convertConditionList(data.conditionList()))
53-
.setLabelAction(convertLabelAction(data.action()))
54-
.build();
51+
LabelApplicationRuleData.Builder convertedDataBuilder =
52+
LabelApplicationRuleData.newBuilder()
53+
.setName(data.name())
54+
.setMatchingCondition(convertConditionList(data.conditionList()))
55+
.setLabelAction(convertLabelAction(data.action()))
56+
.setEnabled(data.enabled());
57+
Optional.ofNullable(data.description()).ifPresent(convertedDataBuilder::setDescription);
58+
return convertedDataBuilder.build();
5559
}
5660

5761
private Action.Operation getOperationFromAction(

hypertrace-graphql-label-application-rules-schema/src/main/java/org/hypertrace/graphql/label/application/rules/dao/LabelApplicationRuleResponseConverter.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,12 @@ private Optional<LabelApplicationRuleData> convertLabelApplicationRuleData(
7474
}
7575
return action.map(
7676
labelAction ->
77-
new ConvertedLabelApplicationRuleData(data.getName(), conditionList, labelAction));
77+
new ConvertedLabelApplicationRuleData(
78+
data.getName(),
79+
conditionList,
80+
labelAction,
81+
data.getEnabled(),
82+
data.hasDescription() ? data.getDescription() : null));
7883
}
7984

8085
private Optional<Action.Operation> convertOperationInAction(
@@ -259,6 +264,8 @@ private static class ConvertedLabelApplicationRuleData implements LabelApplicati
259264
String name;
260265
List<Condition> conditionList;
261266
Action action;
267+
boolean enabled;
268+
String description;
262269
}
263270

264271
@Value

hypertrace-graphql-label-application-rules-schema/src/main/java/org/hypertrace/graphql/label/application/rules/deserialization/LabelApplicationRuleDataDeserializationConfig.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ private static class LabelApplicationRuleDataArgument implements LabelApplicatio
5656

5757
@JsonProperty(ACTION_KEY)
5858
Action action;
59+
60+
@JsonProperty(ENABLED_KEY)
61+
boolean enabled;
62+
63+
@JsonProperty(DESCRIPTION_KEY)
64+
String description;
5965
}
6066

6167
@Value

hypertrace-graphql-label-application-rules-schema/src/main/java/org/hypertrace/graphql/label/application/rules/deserialization/LabelApplicationRuleDeserializationConfig.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@ private static class LabelApplicationRuleDataArgument implements LabelApplicatio
6868

6969
@JsonProperty(ACTION_KEY)
7070
Action action;
71+
72+
@JsonProperty(ENABLED_KEY)
73+
boolean enabled;
74+
75+
@JsonProperty(DESCRIPTION_KEY)
76+
String description;
7177
}
7278

7379
@Value

hypertrace-graphql-label-application-rules-schema/src/main/java/org/hypertrace/graphql/label/application/rules/schema/shared/LabelApplicationRuleData.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import graphql.annotations.annotationTypes.GraphQLName;
55
import graphql.annotations.annotationTypes.GraphQLNonNull;
66
import java.util.List;
7+
import javax.annotation.Nullable;
78

89
@GraphQLName(LabelApplicationRuleData.TYPE_NAME)
910
public interface LabelApplicationRuleData {
@@ -13,6 +14,8 @@ public interface LabelApplicationRuleData {
1314
String NAME_KEY = "name";
1415
String CONDITION_LIST_KEY = "conditionList";
1516
String ACTION_KEY = "action";
17+
String ENABLED_KEY = "enabled";
18+
String DESCRIPTION_KEY = "description";
1619

1720
@GraphQLField
1821
@GraphQLNonNull
@@ -28,4 +31,14 @@ public interface LabelApplicationRuleData {
2831
@GraphQLNonNull
2932
@GraphQLName(ACTION_KEY)
3033
Action action();
34+
35+
@GraphQLField
36+
@GraphQLNonNull
37+
@GraphQLName(ENABLED_KEY)
38+
boolean enabled();
39+
40+
@GraphQLField
41+
@Nullable
42+
@GraphQLName(DESCRIPTION_KEY)
43+
String description();
3144
}

hypertrace-graphql-platform/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ dependencies {
1212
api("org.hypertrace.entity.service:entity-type-service-rx-client:0.5.6")
1313
api("org.hypertrace.config.service:spaces-config-service-api:0.1.1")
1414
api("org.hypertrace.config.service:labels-config-service-api:0.1.15")
15-
api("org.hypertrace.config.service:label-application-rule-config-service-api:0.1.15")
15+
api("org.hypertrace.config.service:label-application-rule-config-service-api:0.1.16")
1616
}
1717
}

0 commit comments

Comments
 (0)