Skip to content

refactor: separate label request builder #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #103 (be8e685) into ENG-11241_2 (31dddca) will decrease coverage by 0.50%.
The diff coverage is 17.14%.

Impacted file tree graph

@@                Coverage Diff                @@
##             ENG-11241_2     #103      +/-   ##
=================================================
- Coverage          22.30%   21.79%   -0.51%     
  Complexity            67       67              
=================================================
  Files                 64       65       +1     
  Lines               1681     1679       -2     
  Branches              57       52       -5     
=================================================
- Hits                 375      366       -9     
- Misses              1296     1305       +9     
+ Partials              10        8       -2     
Flag Coverage Δ
unit 21.79% <17.14%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tity/request/DefaultEntityLabelRequestBuilder.java 0.00% <0.00%> (ø)
...ql/entity/request/DefaultEntityRequestBuilder.java 0.00% <0.00%> (ø)
...ce/graphql/entity/request/EntityRequestModule.java 0.00% <0.00%> (ø)
...entity/request/NeighborEntitiesRequestBuilder.java 0.00% <0.00%> (ø)
...phql/entity/joiner/DefaultEntityJoinerBuilder.java 89.74% <100.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31dddca...be8e685. Read the comment docs.

@github-actions

This comment has been minimized.

…graphql/entity/request/DefaultEntityLabelRequestBuilder.java
@github-actions
Copy link

Unit Test Results

10 files  ±0  10 suites  ±0   10s ⏱️ ±0s
20 tests ±0  20 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit be8e685. ± Comparison against base commit 31dddca.

@saxenakshitiz saxenakshitiz merged commit be8e685 into ENG-11241_2 Sep 16, 2021
@saxenakshitiz saxenakshitiz deleted the ENG-11241_2-aaron branch September 16, 2021 15:50
skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants