ENG-11241: Changes to fetch labels as part of entity joiner #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saxenakshitiz
commented
Sep 16, 2021
saxenakshitiz
commented
- Updated entity joiner request builder to fetch labels
- No change needed in NeighborEntitiesRequestBuilder as it is called from DefaultEntityRequestBuilder which handles labels fetching part
- Minor refactoring
1. Updated entity joiner request builder to fetch labels 2. No change needed in NeighborEntitiesRequestBuilder as it is called from DefaultEntityRequestBuilder which handles labels fetching part 3. Minor refactoring
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
============================================
+ Coverage 21.64% 22.98% +1.34%
- Complexity 67 75 +8
============================================
Files 64 65 +1
Lines 1663 1679 +16
Branches 54 52 -2
============================================
+ Hits 360 386 +26
+ Misses 1295 1284 -11
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
...ty-schema/src/main/java/org/hypertrace/graphql/entity/joiner/DefaultEntityJoinerBuilder.java
Outdated
Show resolved
Hide resolved
…graphql/entity/request/DefaultEntityLabelRequestBuilder.java
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...rc/test/java/org/hypertrace/graphql/entity/request/DefaultEntityLabelRequestBuilderTest.java
Show resolved
Hide resolved
...rc/test/java/org/hypertrace/graphql/entity/request/DefaultEntityLabelRequestBuilderTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
previously approved these changes
Oct 18, 2021
...chema/src/test/java/org/hypertrace/graphql/entity/joiner/DefaultEntityJoinerBuilderTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Oct 19, 2021
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.