Update to 1.85 and Rust Edition 2024 #534
Merged
+314
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
kind/enhancement
simongdavies
added
the
area/infrastructure
simongdavies
requested review from
dblnz,
devigned,
jprendes,
marosset and
syntactically
as code owners
Closed
jprendes
reviewed
May 28, 2025
|
I'll update the dev images to install 1.85.0 |
ludfjig
reviewed
May 28, 2025
simongdavies
force-pushed
the
update-to-1.85
branch
from
b537abe to
958d729
Compare
simongdavies
force-pushed
the
update-to-1.85
branch
2 times, most recently
from
ea8cdd5 to
b093e9a
Compare
Signed-off-by: Simon Davies <[email protected]>
NOTE: I attempted to run flatc to re-generate the flatbuffer generated files but it did not do the updates for 2024 edition. Updated manually for review feedback Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
…--edition` Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
…rence to mutable static Signed-off-by: Simon Davies <[email protected]>
The is mainly the result of running `cargo fix --edition` along with a couple of manula changes to fix clippy "shared reference to mutable static" warnings Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
running rustfmt with edition 2024 creates a lot of noise Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
update-to-1.85
branch
from
7df808b to
3f6e9b9
Compare
jprendes
approved these changes
May 29, 2025
|
@jprendes I am going to merge this and follow up with the nits later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
I retained rustfmt version as 2021, we should update this in a distinct PR as it causes updates to over 80 files