Skip to content

fix undefined variable $definitionClassname #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

fix undefined variable $definitionClassname #1302

merged 1 commit into from
Dec 1, 2017

Conversation

@juliendidier
Copy link
Contributor

@juliendidier juliendidier commented Dec 1, 2017 •
edited
Loading

Due to #1290, the $definitionClassname is not set at OAuthFactory::createEntryPoint (line 155).

This PR fix this, by setting the $definitionClassname variable.

@stloyd stloyd added this to the Release 0.6 milestone Dec 1, 2017
@stloyd stloyd added the Bugfix label Dec 1, 2017
@stloyd stloyd merged commit 668cb39 into hwi:master Dec 1, 2017
@stloyd
Copy link
Collaborator

stloyd commented Dec 1, 2017

@juliendidier Looks good, thanks!

@juliendidier juliendidier deleted the fix-definition-classname branch December 12, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bugfix

Projects

None yet

Milestone

Release 0.6

Development

Successfully merging this pull request may close these issues.

2 participants

@juliendidier @stloyd