Attempting to add Symfony 4 testing for Travis #1290
Conversation
|
Ping! This doesn't affect anything. It just gets the tests running in Symfony 4. |
|
Perhaps we should bring Travis changes in line with FriendsOfSymfony/FOSUserBundle#2639 ? |
soullivaneuh
left a comment
soullivaneuh
left a comment
There was a problem hiding this comment.
Just a variable rename, but it's good for me.
.travis.yml
Outdated
| - php: 7.0 | ||
| env: FOSUSERBUNDLE_VERSION=2.0.* | ||
| - php: 7.1 | ||
| env: DEPENDENCIES=beta |
There was a problem hiding this comment.
STABILITY means more sens according to the action below. Could you please change that?
|
Variable name changed! @XWB We've all been hacking on a "perfect" Let's merge this now (because why not - we want the tests to run on 4). But once that is merged, yea, we should unify the Travis config everywhere - should make life a lot easier. |
|
Curious. The tests are now failing all over. It's not caused by my simple variable change... I think more 4.0 problems are showing now that it's stable. This bundle is actually not 4.0 compat - I'm not sure why my original Travis tests didn't catch this while Symfony 4 was still in beta. |
|
Tests pass! And all the changes were very typical and familiar for supporting Symfony 4. So here's what I think we need to do: A) Merge this if nobody sees any issues Soon, I think we'll start hearing from users asking for Symfony 4 support. Hopefully we can have it be not too far behind :). Let me know how I can help. Cheers! |
|
@weaverryan Great work! Thank you for fixing those deprecations! |
|
@stloyd @weaverryan As Symfony 4.0 is final, wouldn't it be better to replace |
4 participants
See #1289
As I mentioned in FriendsOfSymfony/FOSUserBundle#2639, there may be a better way of doing this. I'm happy to hear if there is :).
Cheers!