Skip to content

renamed x to meaningful variable in resnet.py #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 4, 2022
Merged

renamed x to meaningful variable in resnet.py #677

merged 17 commits into from
Oct 4, 2022

Conversation

@i-am-epic
Copy link
Contributor

@i-am-epic i-am-epic commented Sep 29, 2022

Hello @patil-suraj can you verify it
Thanks

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@i-am-epic i-am-epic mentioned this pull request Sep 29, 2022
Closed
@i-am-epic i-am-epic closed this Sep 29, 2022
@i-am-epic
Copy link
Contributor Author

i-am-epic commented Sep 29, 2022 •
edited
Loading

Black says : Cannot parse: 100:34: def init(self, channels=N one, out_channels=None, use_conv=False, fir_kernel=(1, 3, 3, 1)):
But I have not modified those lines,
can anyone help me understand this issue Thanks :)

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Sep 29, 2022

Hey @i-am-epic - could you try updating your black version?

Re-opening the PR :-)

i-am-epic
i-am-epic commented Sep 29, 2022
View reviewed changes
Copy link
Contributor Author

@i-am-epic i-am-epic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed variables x and p

@i-am-epic
Copy link
Contributor Author

i-am-epic commented Sep 29, 2022

This was my first Contribution,
any more changes let me know,
Thank you

patil-suraj
patil-suraj suggested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @i-am-epic ! Here we should only rename the single letter variables. Other names are well chosen so let's not change them. We should update the PR accordingly.

@i-am-epic i-am-epic requested a review from patil-suraj October 1, 2022 07:40
@i-am-epic
Copy link
Contributor Author

i-am-epic commented Oct 2, 2022

@patil-suraj can you verify the updated code
Thanks :)

patil-suraj
patil-suraj approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for working on this. Should be good to merge once the tests pass.

@patrickvonplaten patrickvonplaten merged commit 7265dd8 into huggingface:main Oct 4, 2022
@i-am-epic
Copy link
Contributor Author

i-am-epic commented Oct 5, 2022

Thanks for the guidance and help,
as this was my first contribution and PR, it helped me to learn a lot and this is just the beginning of my contributions.
:)

prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
@i-am-epic @patrickvonplaten @patil-suraj
renamed x to meaningful variable in resnet.py (huggingface#677)
dae2931 
* renamed single letter variables

* renamed x to meaningful variable in resnet.py

Hello @patil-suraj can you verify it
Thanks

* Reformatted using black

* renamed x to meaningful variable in resnet.py

Hello @patil-suraj can you verify it
Thanks

* reformatted the files

* modified unboundlocalerror in line 374

* removed referenced before error

* renamed single variable x -> hidden_state, p-> pad_value

Co-authored-by: Nikhil A V <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: Suraj Patil <[email protected]>
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
@qedawkins
[SD] Deduplicate initial noise generation (huggingface#677)
ff536f6
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@i-am-epic @patrickvonplaten @patil-suraj
renamed x to meaningful variable in resnet.py (huggingface#677)
7cfdff2 
* renamed single letter variables

* renamed x to meaningful variable in resnet.py

Hello @patil-suraj can you verify it
Thanks

* Reformatted using black

* renamed x to meaningful variable in resnet.py

Hello @patil-suraj can you verify it
Thanks

* reformatted the files

* modified unboundlocalerror in line 374

* removed referenced before error

* renamed single variable x -> hidden_state, p-> pad_value

Co-authored-by: Nikhil A V <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: Suraj Patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@patil-suraj patil-suraj patil-suraj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@i-am-epic @HuggingFaceDocBuilderDev @patrickvonplaten @patil-suraj